From 716724df0fee78a8976d5255096e000af29daad1 Mon Sep 17 00:00:00 2001 From: Nicholas Tay Date: Thu, 24 Mar 2022 15:46:48 +1100 Subject: Update LEARNING goals --- LEARNING.md | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/LEARNING.md b/LEARNING.md index d106f2d..a01f53c 100644 --- a/LEARNING.md +++ b/LEARNING.md @@ -13,7 +13,19 @@ - Basically for constraints like `make.top.equalToSuperview().inset(8)` - Test this out with accessibility options to see how reflow - image and labels may fight with each other - [x] Rip out Storyboard entirely -- [ ] Extract network requests into own class +- [x] Extract network requests into own class - Make network class generic - See https://stackoverflow.com/questions/65576832/how-can-i-make-my-networking-class-generic-in-swift -- [ ] The 'coordinator pattern' + - TODO: Name it 'xxFetcher' +- [x] The 'coordinator pattern' + - Don't worry about child coordinator + - Decouple VCs from views +- [ ] Custom views, separate View from VC + - HasCustomView, see FeedbackVC + - OK to have how I had it, taking in set data as string/images and not a ViewModel, since View could be reused in this way without coupling it to ViewModel, but either way works +- [ ] Presenter + - VC shouldn't see PenguinItem, only the one for rendering, e.g. 'PenguinItemModel' + - ViewModel struct can be together with Presenter file if simple +- [ ] Background thread + - DispatchQueue backgroundThread + - Just one place on the presenter to fire back on Main -- cgit